Error: max_wasm_stack size cannot exceed the async_stack_size #9298
Labels
bug
Incorrect behavior in the current implementation that needs fixing
Comments
pavelsavara
added
the
bug
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this issue
Sep 24, 2024
Recently the `wasmtime` CLI switched from sync to async to handle interrupting host APIs in WASI. Previously the CLI provided no means to configure the async stack size, however, which now means that when increasing the max wasm stack the CLI prints an error that cannot be resolved about the wasm stack being larger than the async stack. This commit fixes this issue by both adding a configuration option for the async stack size and additionally automatically increasing the async stack size when only the wasm stack size is provided. Closes bytecodealliance#9298
|
Thanks for the report! This was an oversight when turning on async on the CLI and should be fixed in #9302 |
github-merge-queue bot
pushed a commit
that referenced
this issue
Sep 24, 2024
* Add `-Wasync-stack-size`, automatically configure it too Recently the `wasmtime` CLI switched from sync to async to handle interrupting host APIs in WASI. Previously the CLI provided no means to configure the async stack size, however, which now means that when increasing the max wasm stack the CLI prints an error that cannot be resolved about the wasm stack being larger than the async stack. This commit fixes this issue by both adding a configuration option for the async stack size and additionally automatically increasing the async stack size when only the wasm stack size is provided. Closes #9298 * Fix feature-gated build
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this issue
Sep 24, 2024
…iance#9302) * Add `-Wasync-stack-size`, automatically configure it too Recently the `wasmtime` CLI switched from sync to async to handle interrupting host APIs in WASI. Previously the CLI provided no means to configure the async stack size, however, which now means that when increasing the max wasm stack the CLI prints an error that cannot be resolved about the wasm stack being larger than the async stack. This commit fixes this issue by both adding a configuration option for the async stack size and additionally automatically increasing the async stack size when only the wasm stack size is provided. Closes bytecodealliance#9298 * Fix feature-gated build
fitzgen
pushed a commit
that referenced
this issue
Sep 24, 2024
* Add `-Wasync-stack-size`, automatically configure it too Recently the `wasmtime` CLI switched from sync to async to handle interrupting host APIs in WASI. Previously the CLI provided no means to configure the async stack size, however, which now means that when increasing the max wasm stack the CLI prints an error that cannot be resolved about the wasm stack being larger than the async stack. This commit fixes this issue by both adding a configuration option for the async stack size and additionally automatically increasing the async stack size when only the wasm stack size is provided. Closes #9298 * Fix feature-gated build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Test Case
Testing dotnet AOT with the new wasmtime v 25 in the dotnet CI.
The full log
Steps to Reproduce
wasmtime --dir=. --wasm max-wasm-stack=134217728 --wasi http --wasi inherit-network --wasi allow-ip-name-lookup dotnet.wasmExpected Results
probably we need a way how to specify
--wasm async-stack-size=134217728on cli.But I'm not sure I understand the feature well enough.
Actual Results
Error: max_wasm_stack size cannot exceed the async_stack_sizeVersions and Environment
Wasmtime version or commit: wasmtime 25.0.0 (0b195ef 2024-09-20)
Operating system: ubuntu-22.04
Architecture: x64
Extra Info
Anything else you'd like to add?
The text was updated successfully, but these errors were encountered: