ISLE i64_from_iconst extractor can match f32const/f64const
#8723
Comments
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this issue
Jun 3, 2024
Previously this extractor would additionally match `f32const` and `f64const` which while theoretically not the end of the world can be confusing. Nowadays switch it to instead only matching the `iconst` instruction, as the name implies, and if necessary matching float constants is probably best done through separate ISLE lowering rules. Closes bytecodealliance#8723
github-merge-queue bot
pushed a commit
that referenced
this issue
Jun 4, 2024
Previously this extractor would additionally match `f32const` and `f64const` which while theoretically not the end of the world can be confusing. Nowadays switch it to instead only matching the `iconst` instruction, as the name implies, and if necessary matching float constants is probably best done through separate ISLE lowering rules. Closes #8723
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I ran into this bug on #8719 but the current definition of
i64_from_iconstcan match thef32constandf64constnodes in addition toiconst. This seems counterintuitive given the name of the extractor, but I'm not sure how to best fix myself.The text was updated successfully, but these errors were encountered: