Review feedback.

bytecodealliance · Oct 11, 2023 · 556a9eb · 556a9eb
1 parent 1bb20ec
commit 556a9eb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/cranelift/codegen/src/ir/memtype.rs b/cranelift/codegen/src/ir/memtype.rs
@@ -62,6 +62,9 @@
 //! - A discriminated union is a union of several memory types
 //!   together with a tag field. This will be useful to model and
 //!   verify subtyping/downcasting for Wasm GC, among other uses.
+//!
+//! - Nullability on pointer fields: the fact will hold only if the
+//!   field is not null (all zero bits).
 
 use crate::ir::pcc::Fact;
 use crate::ir::Type;

diff --git a/cranelift/filetests/filetests/pcc/fail/simple.clif b/cranelift/filetests/filetests/pcc/fail/simple.clif
@@ -16,7 +16,7 @@ block0(v0 ! mem(mt0, 0): i64, v1 ! max(32, 0xffff_ffff): i32):
 
 ;; Check that the offset in the `mem` is validated too.
 
-function %simple1(i64 vmctx, i32) -> i8 {
+function %simple2(i64 vmctx, i32) -> i8 {
     mt0 = memory 0x8000_0000
 block0(v0 ! mem(mt0, 0): i64, v1 ! max(32, 0xffff_ffff): i32):
     v2 ! max(64, 0xffff_ffff) = uextend.i64 v1