Skip to content

Commit

Permalink
cranelift: Merge abi and abi_impl modules (#4805)
Browse files Browse the repository at this point in the history
  • Loading branch information
fitzgen authored Aug 29, 2022
1 parent dd81e5a commit 5392d7c
Show file tree
Hide file tree
Showing 7 changed files with 1,962 additions and 1,969 deletions.
2 changes: 1 addition & 1 deletion cranelift/codegen/src/isa/aarch64/abi.rs
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,7 @@ impl ABIMachineSpec for AArch64MachineDeps {
}

// Returns stack bytes used as well as instructions. Does not adjust
// nominal SP offset; abi_impl generic code will do that.
// nominal SP offset; abi generic code will do that.
fn gen_clobber_save(
_call_conv: isa::CallConv,
setup_frame: bool,
Expand Down
4 changes: 2 additions & 2 deletions cranelift/codegen/src/isa/s390x/abi.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//! Implementation of a standard S390x ABI.
//!
//! This machine uses the "vanilla" ABI implementation from abi_impl.rs,
//! This machine uses the "vanilla" ABI implementation from abi.rs,
//! however a few details are different from the description there:
//!
//! - On s390x, the caller must provide a "register save area" of 160
Expand Down Expand Up @@ -575,7 +575,7 @@ impl ABIMachineSpec for S390xMachineDeps {
}

// Returns stack bytes used as well as instructions. Does not adjust
// nominal SP offset; abi_impl generic code will do that.
// nominal SP offset; abi generic code will do that.
fn gen_clobber_save(
_call_conv: isa::CallConv,
_setup_frame: bool,
Expand Down
2 changes: 1 addition & 1 deletion cranelift/codegen/src/isa/s390x/lower/isle.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ use crate::{
},
isa::unwind::UnwindInst,
isa::CallConv,
machinst::abi_impl::ABIMachineSpec,
machinst::abi::ABIMachineSpec,
machinst::{InsnOutput, Lower, MachInst, VCodeConstant, VCodeConstantData},
};
use regalloc2::PReg;
Expand Down
2 changes: 1 addition & 1 deletion cranelift/codegen/src/isa/x64/abi.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use crate::ir::{self, types, LibCall, MemFlags, Opcode, Signature, TrapCode, Typ
use crate::ir::{types::*, ExternalName};
use crate::isa;
use crate::isa::{unwind::UnwindInst, x64::inst::*, x64::settings as x64_settings, CallConv};
use crate::machinst::abi_impl::*;
use crate::machinst::abi::*;
use crate::machinst::*;
use crate::settings;
use crate::{CodegenError, CodegenResult};
Expand Down
Loading

0 comments on commit 5392d7c

Please sign in to comment.