Skip to content

Commit

Permalink
Remove the implementation of wasi-crypto (#6816)
Browse files Browse the repository at this point in the history
* Remove the implementation of wasi-crypto

This commit is a follow-up to the discussion on #6732. This removes
Wasmtime's implementation of the wasi-crypto proposal from in-tree along
with its various support in CI, configuration, etc. See the discussion
on #6732 for the full information but at a high level the main reasons
for removing the implementation at this time are:

* There is not currently an active maintainer of the Wasmtime
  integration here for wasi-crypto.
* There are known issues with the code quality of the implementation
  such as transmutes of guest-owned memory to `&'static mut [u8]` and
  known unsafety in dependencies.
* The size and breadth of the dependency tree brings maintenance burden
  and overhead to managing Wasmtime's dependency tree.

As mentioned on the issue this commit does not mean that Wasmtime
doesn't want to implement the wasi-crypto proposal. Instead the "tier 3"
status of wasi-crypto needs to be re-attained to be included back
in-tree, which would mean resolving the above issues.

Note that this commit is intentionally just after the 13.0.0 branch
point which means that this is slated for Wasmtime 14 to be released on
September 20.

* Remove some cfgs

* Remove wasi-crypto CI
  • Loading branch information
alexcrichton authored Aug 8, 2023
1 parent 3878a00 commit 2897e40
Show file tree
Hide file tree
Showing 28 changed files with 74 additions and 3,699 deletions.
23 changes: 0 additions & 23 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -498,28 +498,6 @@ jobs:
env:
GH_TOKEN: ${{ github.token }}

# Build and test the wasi-crypto module.
test_wasi_crypto:
needs: determine
if: needs.determine.outputs.run-full
name: Test wasi-crypto module
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
submodules: true
- run: rustup update stable && rustup default stable
- run: rustup target add wasm32-wasi
- run: ./ci/run-wasi-crypto-example.sh
env:
RUST_BACKTRACE: 1

# common logic to cancel the entire run if this job fails
- run: gh run cancel ${{ github.run_id }}
if: failure() && github.event_name != 'pull_request'
env:
GH_TOKEN: ${{ github.token }}

build-preview1-component-adapter:
name: Build wasi-preview1-component-adapter
needs: determine
Expand Down Expand Up @@ -768,7 +746,6 @@ jobs:
- checks_winarm64
- fuzz_targets
- test_wasi_nn
- test_wasi_crypto
- bench
- meta_deterministic_check
- verify-publish
Expand Down
3 changes: 0 additions & 3 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@
[submodule "crates/wasi-nn/spec"]
path = crates/wasi-nn/spec
url = https://github.com/WebAssembly/wasi-nn
[submodule "crates/wasi-crypto/spec"]
path = crates/wasi-crypto/spec
url = https://github.com/WebAssembly/wasi-crypto.git
[submodule "tests/wasi_testsuite/wasi-threads"]
path = tests/wasi_testsuite/wasi-threads
url = https://github.com/WebAssembly/wasi-threads
Expand Down
Loading

0 comments on commit 2897e40

Please sign in to comment.