Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Retries="10" attribute to the DownloadFile task #222

Closed

Conversation

kpreisser
Copy link
Contributor

@kpreisser kpreisser commented Feb 7, 2023

Add a Retries="10" attribute to the DownloadFile task, to check whether it can avoid the failed download issue in the Windows CI runner.

Edit: Unfortunately it seems IsRetriable returns false, so the task doesn't attempt to retry the download.

…er it can avoid the failed download issue in the Windows CI runner.
@kpreisser kpreisser closed this Feb 7, 2023
@kpreisser kpreisser deleted the test-download-retry branch February 7, 2023 14:50
@peterhuene
Copy link
Member

Yeah, unfortunately the underlying exception isn't "retryable".

The good news is that there is a fix to the DownloadFile task that might expose what the underlying issue is with our flaky Windows CI (my money is on a TLS issue with GitHub).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants