Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI. #12

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Fix CI. #12

merged 1 commit into from
Apr 30, 2020

Conversation

peterhuene
Copy link
Member

This PR fixes CI as currently Wasmtime will panic if non-funcref tables are
used (not currently implemented).

This commit fixes CI as currently Wasmtime will panic if non-funcref tables are
used (not currently implemented).
@peterhuene
Copy link
Member Author

This appears to have been was regressed by bytecodealliance/wasmtime#1524.

Previously we were just cloning an internal table type in Table::ty and now we're calling TableType::from_wasmtime_table which panics if the element type is not funcref.

@sunfishcode previously the C API was able to describe anyref table imports and exports, but now we hit the assertion in TableType::from_wasmtime_table. Given that anyref tables aren't really implemented yet in Wasmtime, how should we fix this? Should the .NET tests simply just stick to funcref tables in the test modules until Wasmtime reference types implementation is more complete or should we relax the assertion such that anyref is valid?

Wasmtime will unimplemented! panic with the following module despite reference types being enabled:

(module
  (table $t 1 anyref)
)

@peterhuene
Copy link
Member Author

I'm going to merge this for now and we can revisit when more of the reference types proposal is implemented.

@peterhuene peterhuene merged commit 859ecdf into bytecodealliance:master Apr 30, 2020
@peterhuene peterhuene deleted the fix-ci branch April 30, 2020 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant