wasm-mutate: Clean up egg rule definitions and extract smallest AST size expression when reducing
#413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Jacarte |
|
Oh, the other thing that this does is make the rules unidirectional (most are bidirectional by default) when we are reducing, so that we only make the expression smaller. This could, in theory, miss out on some size-reducing optimizations that take a long, circuitous route to get to their final form, but I think that will be pretty rare in practice and we should get a nice speed up this way since we are dealing with fewer rewrite rules. |
Reorganizes and reformats our `egg` rules. Also adds a few missing rules, such as some commutativity and associativity rules and some non-semantics-preserving rules.
… peephole mutator This ensures that we are actually reducing the expression (or at least not making it larger).
fitzgen
force-pushed
the
clean-up-wasm-mutate-rules
branch
from
13f0178
to
4cd9d27
Compare
alexcrichton
added a commit
to alexcrichton/wasm-tools
that referenced
this pull request
Nov 16, 2022
* syntax: world + interface Signed-off-by: Brian H <brian.hardock@fermyon.com> * Get tests passing Remove all parsing tests related to `use` along the way to get re-added once `use` is re-implemented for top-level worlds. * Update wit-parser tests to worlds Drop usage of the old `Interface::parse_file` function. * Add some basic tests for world Assert some assorted failures as well as a basic successful structure. * Remove existing support for `use` This will come back shortly with worlds, but for now nothing uses this in the repository any more and it's not implemented within the resolver so temporarily remove it. * Thread through docs on worlds/interfaces * Remove docs from imports/exports They're not threaded anywhere right now so remove them. Can be added back in if needed in the future. * Implement temporary stopgap of `default export` * Fix demo build Signed-off-by: Brian H <brian.hardock@fermyon.com> Co-authored-by: Alex Crichton <alex@alexcrichton.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.