Align type size calculation in wasmparser/wasm-smith #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the type size calculation in wasmparser to more closely align with that of wasm-smith. Previously wasmparser would conservatively say that the type size of the instance of an instantiated module was the same as that of the module that was being instantiated, but wasm-smith only considered the size of the exports. Additionally the `+1` for each item happened in wasm-smith outside of the `size` calculation rather than inside. This fixes both of these issues in wasmparser's validator, the main fix being having instances count far less towards the type size budget because the imports of the instantiated module are no longer considered in the type size of the instance itself.
fitzgen
approved these changes
May 19, 2021
alexcrichton
pushed a commit
to alexcrichton/wasm-tools
that referenced
this pull request
Nov 16, 2022
Closes bytecodealliance#274 Signed-off-by: Klim Tsoutsman <klim@tsoutsman.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the type size calculation in wasmparser to more
closely align with that of wasm-smith. Previously wasmparser would
conservatively say that the type size of the instance of an instantiated
module was the same as that of the module that was being instantiated,
but wasm-smith only considered the size of the exports. Additionally the
+1for each item happened in wasm-smith outside of thesizecalculation rather than inside.
This fixes both of these issues in wasmparser's validator, the main fix
being having instances count far less towards the type size budget
because the imports of the instantiated module are no longer considered
in the type size of the instance itself.