Enable new WIT encoding by default #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables the new encoding for WIT packages in WebAssembly components described in WebAssembly/component-model#248 and originally implemented in bytecodealliance#1252. Support for the new encoding has been in a wasm-tools for a bit and it's also released with Wasmtime 14. This switch means that infrastructure will start being exposed to it by default now. Support for the old encoding remains to assist with interop as well. In a release or two support for creating the old encoding will be removed.
pchickey
approved these changes
Nov 1, 2023
alexcrichton
added a commit
to alexcrichton/wasm-tools
that referenced
this pull request
Nov 6, 2023
Going to pull bytecodealliance#1274, bytecodealliance#1270, and bytecodealliance#1269 into Wasmtime.
Merged
alexcrichton
added a commit
that referenced
this pull request
Nov 6, 2023
alexcrichton
added a commit
to alexcrichton/wasm-tools
that referenced
this pull request
Sep 11, 2024
This commit removes support for the "v1" encoding of WIT packages into WebAssembly. This was originally migrated to v2 in bytecodealliance#1252 and v2 was enabled by default in bytecodealliance#1274. This finishes the transition by removing support for creating the old encoding.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
* Remove v1 encoding support for WIT documents/worlds This commit removes support for the "v1" encoding of WIT packages into WebAssembly. This was originally migrated to v2 in #1252 and v2 was enabled by default in #1274. This finishes the transition by removing support for creating the old encoding. * Fix fuzzer build * Update outdated comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables the new encoding for WIT packages in WebAssembly components described in WebAssembly/component-model#248 and originally implemented in #1252. Support for the new encoding has been in a wasm-tools for a bit and it's also released with Wasmtime 14. This switch means that infrastructure will start being exposed to it by default now. Support for the old encoding remains to assist with interop as well. In a release or two support for creating the old encoding will be removed.