Full review #8
Merged
Full review #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add github actions to compile and test x64 benchmarks * Refactor driver to match refactored sightglass * Continue refactor and cleanup. Better use of df * Prints out efficiency and wasm scores * Remove unneeded comments * Add printing of results to a file and the screen * Improve quiet printing * Add simdscore placeholder and validate runall * Update tag for docker images * Update workflow to include running of all available benchmarks
Code of conduct is a copy from wasmtime repo.
|
This PR is identical to the set of commits that make up main. The purpose of this PR is to allow a review of that full code base that makes up main. Subsequent commits here to address review comments will be pushed to main after this PR is approved. |
jlb6740
force-pushed
the
full_review
branch
from
1fc874a
to
cb2ceb3
Compare
jlb6740
force-pushed
the
full_review
branch
from
cb2ceb3
to
e83e2e9
Compare
rahulchaphalkar
approved these changes
Sep 18, 2023
jlb6740
added a commit
that referenced
this pull request
Sep 18, 2023
* Initial commit for WasmScore" * add github actions to compile and test x64 benchmarks (#1) * Add github actions to compile and test x64 benchmarks * Refactor driver to match refactored sightglass * Continue refactor and cleanup. Better use of df * Prints out efficiency and wasm scores * Remove unneeded comments * Add printing of results to a file and the screen * Improve quiet printing * Add simdscore placeholder and validate runall * Update tag for docker images * Update workflow to include running of all available benchmarks * Update wasmtime commit * Add code of conduct Code of conduct is a copy from wasmtime repo. * Add contributor documentation * Add license agreement * Update security policy * Add dependabot support for pip * Update simplify config.inc * Use a local benchmarks directory instead of the Sightglass version * Fix for failures caused by missing results directory on some runs * Remove unnecessary installs in Dockerfile * Separate security section to it's own file * Update printed comments * Update container entry point and build message * Update README and add example screenshots in asset folder
rahulchaphalkar
pushed a commit
that referenced
this pull request
Sep 18, 2023
* Initial commit for WasmScore" * add github actions to compile and test x64 benchmarks (#1) * Add github actions to compile and test x64 benchmarks * Refactor driver to match refactored sightglass * Continue refactor and cleanup. Better use of df * Prints out efficiency and wasm scores * Remove unneeded comments * Add printing of results to a file and the screen * Improve quiet printing * Add simdscore placeholder and validate runall * Update tag for docker images * Update workflow to include running of all available benchmarks * Update wasmtime commit * Add code of conduct Code of conduct is a copy from wasmtime repo. * Add contributor documentation * Add license agreement * Update security policy * Add dependabot support for pip * Update simplify config.inc * Use a local benchmarks directory instead of the Sightglass version * Fix for failures caused by missing results directory on some runs * Remove unnecessary installs in Dockerfile * Separate security section to it's own file * Update printed comments * Update container entry point and build message * Update README and add example screenshots in asset folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.