Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

fix compile failed by wasmtime::component::Error dropped #46

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

fuxiaohei
Copy link
Contributor

@fuxiaohei fuxiaohei commented Jan 4, 2023

This is fix for wasmtime::component::Error dropped from bytecodealliance/wasmtime#5397 to keep host compiling.

I found #32 and #26 talking about this case. PR is outdated and It seems a new design for HostResult is comming.

But now I'm trying to run wasm component-model with wasi host bindings. So I think host should be compiled correctly.

@sunfishcode
Copy link
Member

Thanks! I think this makes sense. I expect there are more changes coming up for how we handle errors, but for now it's good to stay current with the bindings generator.

@sunfishcode sunfishcode merged commit 35ba79e into bytecodealliance:main Jan 4, 2023
@sunfishcode sunfishcode mentioned this pull request Jan 4, 2023
@sunfishcode
Copy link
Member

There's one more failure now on main due to a test added in #45. If anyone's able to submit a PR that'd be great, otherwise I'll do it when I get a chance in a few days.

@dicej
Copy link
Collaborator

dicej commented Jan 4, 2023

@sunfishcode #47

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants