Fully thread the source-compression value
#761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the handling of the `source-compression` option when `C dynamic` is set. Even though the codegen option gropup defines the options as `true` by default, it was not threaded correctly. Additionally this commit set `source-compression` as `true` in the default implementation of the builders to ensure that the CLI options intent is accurately reflected.
saulecabrera
force-pushed
the
fully-thread-source-compression
branch
from
d61195c
to
c76ea9d
Compare
jeffcharles
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the handling of the
source-compressionoption whenC dynamicis set. Even though the codegen option gropup defines theoptions as
trueby default, it was not threaded correctly.Additionally this commit sets
source-compressionastruein thedefault implementation of the builders to ensure that the CLI options
intent is accurately reflected.
Checklist
javy-cliandjavy-coredo not require updating CHANGELOG files.