Add support for -J option group
#748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for the `-J` option group and enables `javy-json` and `override-json-parse-and-stringify` by default. Additionally, this change improves how the javy cli integration tests are defined by introducing a `javy_cli_test` which: * Produces a test per supported command (`compile` and `build`) * Provides a set of defaults depending on the command under test Generating a test per command improves the developer experience of determining failures on particular command configurations. Lastly, this change bumps the provider to v3, given that new funcionality is introduced as part of enabling `javy-json` and `override-json-parse-and-stringify`. In order to test that the `compile` command remains "frozen", using version 2 of the provider, this commit introduces a static copy of the v2 provided downloaded from the releases section.
|
The failures in CI are caused by rust-lang/rust#123748; in CI, we're using the latest stable, which got updated today. I can repro those failures locally by updating the toolchain. |
saulecabrera
force-pushed
the
handle-more-js-opts
branch
from
878384c
to
9effbfc
Compare
saulecabrera
force-pushed
the
handle-more-js-opts
branch
from
9effbfc
to
d886338
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for the
-Joption group and enablesjavy-jsonandoverride-json-parse-and-stringifyby default.Additionally, this change improves how the javy cli integration tests are defined by introducing a
javy_cli_testwhich:compileandbuild)Generating a test per command improves the developer experience of determining failures on particular command configurations.
Lastly, this change bumps the provider to v3, given that new funcionality is introduced as part of enabling
javy-jsonandoverride-json-parse-and-stringify. In order to test that thecompilecommand remains "frozen", using version 2 of the provider, this commit introduces a static copy of the v2 provided downloaded from the releases section.javy-cliandjavy-coredo not require updating CHANGELOG files.