Fix multiword exports #424
Conversation
crates/cli/src/exports.rs
Outdated
| pub js: String, | ||
| } | ||
|
|
||
| pub fn determine_js_exports(js: &JS, wit: &Path, wit_world: &str) -> Result<Vec<Export>> { |
There was a problem hiding this comment.
Can we add some documentation here or rename this function to something that indicates that we are renaming and searching the relevant exports (e.g process_exports)? At a first glance it was not evident, at least to me, that here's where all the casing is happening.
There was a problem hiding this comment.
My thinking with determine_js_exports was it was getting a list of WIT exports and determining which JS export corresponded to each of them. There isn't any renaming going on, the data structure that gets sent back is essentially (wit_export, js_export). Maybe that counts a rename? I didn't think about it that way. That said, I'll use a different name given the current one seems to not be clear. process_exports seems fine to me so I'll update to use that.
Fixes #420.
We translate the kebab-cased identifiers in the WIT file to camel-cased identifiers in the JavaScript and retain the kebab-cased identifiers for the name of the Wasm function exports since the WIT describes the export names for the Wasm.