Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added wasmtime wasi args for cargo component serve #308

Merged
merged 1 commit into from
Jun 1, 2024
Merged

added wasmtime wasi args for cargo component serve #308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ fn get_runner(serve: bool) -> Result<PathAndArgs> {
(
PathAndArgs::new("wasmtime")
.args(if serve {
vec!["serve"]
vec!["serve", "-S", "common", "-S", "http"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "common" is being deprecated. Too early to use "cli"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good catch. I have an issue to track making that change: #306

It was recently failing CI tests switching to "cli" instead of "common". Need to track down why it is still grabbing an older release of wasmtime.

} else {
vec!["-S", "preview2", "-S", "common"]
})
Expand Down