fix: handle "." in path lookup #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, yes we can better handle this case, would be great to land a fix. The assertion seems a bit odd though, are you able to fix the failing test here? Let me know when this is ready for review or if you need feedback at all. |
kateinoigakukun
force-pushed
the
pr-ac29b9817bc1413c3017ec354234b172fb1814c6
branch
from
dccfdfa
to
d677f6e
Compare
Such lookup usually happens when reading a preopened directory entries through wasi-libc
kateinoigakukun
force-pushed
the
pr-ac29b9817bc1413c3017ec354234b172fb1814c6
branch
from
d677f6e
to
f0160f6
Compare
|
I just needed to update the binary artifacts 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such lookup usually happens when reading a preopened directory entries through wasi-libc