upgrade react-lifecycles-compat #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrySound
approved these changes
May 17, 2018
soda-x
changed the title
wuweiweiwu
reviewed
May 18, 2018
| @@ -236,8 +236,12 @@ export default class GridExample extends React.PureComponent { | |||
| _renderLeftSideCell({columnIndex, key, rowIndex, style}) { | |||
| const rowClass = | |||
| rowIndex % 2 === 0 | |||
| ? columnIndex % 2 === 0 ? styles.evenRow : styles.oddRow | |||
| : columnIndex % 2 !== 0 ? styles.evenRow : styles.oddRow; | |||
| ? columnIndex % 2 === 0 | |||
There was a problem hiding this comment.
239:32 error Replace `·?·styles.evenRow` with `⏎··········?·styles.evenRow⏎·········` prettier/prettier
240:32 error Replace `·?·styles.evenRow` with `⏎··········?·styles.evenRow⏎·········` prettier/prettierThere was a problem hiding this comment.
Because these codes would cause eslint errors so I fixed it 0.0
wuweiweiwu
approved these changes
May 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-->
edit:It was confirmed that this bug was caused by my local multiple react-lifecycles-compat versions.
So I change this PR's title.
But I'm looking forward this PR could be merged.
I fixed eslint errors and upgraded react-lifecycles-compat to newest version.