Added scrollToRow and scrollToColumn support for ssr #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microcood This is currently blocked by #1053 We'll take a look at this as soon as that is in. |
|
@microcood #1053 is in! There are some changes to how some values (ex: :) |
microcood
force-pushed
the
ssr-scroll-support
branch
from
94dfb20
to
87fea87
Compare
|
Updated ☝️ |
|
All tests pass and everything looks good! Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Render cells defined with scrollToRow and scrollToColumn with server dom. I consider this as an intuitive behaviour, also was not confronted in #587