Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Let me know your thoughts about this implementation.
I think it is what was expected. With order 1 (k=1) I got the same results than the current function.
I only implemented the function for the DataFrames, and if it is validated it will be straightforward to do the same for the groups.
I would also like to replace those for loops, but for the moment I was more interested in the correctness of the results :)
fix #22
NB this is a working version. I implemented my fix in a _v2 function so that the other function still works :)