added macOS support and removed any View in CachedAsyncImage View #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iankoex Hi! macOS support is very good, I'll be glad to add it. But I specifically did not use a generic in order to preserve the ability to use different constructors, for example, an error or placeholder parameter is not always needed. |
|
That's alright. |
bullinnyc
force-pushed
the
main
branch
6 times, most recently
from
7a65b56
to
a5e0a6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added support for macOS by using typealias for NSImage and UIImage.
I have also removed any View and using generics for placeholder, image and error views.