Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get tests working on Windows, fix issue #11 #13

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Get tests working on Windows, fix issue #11 #13

wants to merge 5 commits into from

Commits on Apr 24, 2017

  1. Fix too many values to unpack on Windows

    On Windows, zc.buildout.easy_install.scripts returns a 2 element list
    containing py.exe and py-script.py
    daybarr committed Apr 24, 2017
    Configuration menu
    Copy the full SHA
    cd635a9 View commit details
    Browse the repository at this point in the history
  2. Work around .whl in use during teardown on Windows

    I think wheel.install.WheelFile isn't properly managing its handles and
    doesn't close the zipfile when it's done with it. Force a gc at tearDown
    time to clean up any references and so close the handle prior to the
    rmtree done by buildoutTearDown which was failing on Windows with:
    
    WindowsError: [Error 32] The process cannot access the file because it
    is being used by another process:
    'c:\\...\\_TEST_\\sample_eggs\\demo-1.0-py2-none-any.whl'
    
    Also, can't use self.register_teardown because (bug?) buildoutTearDown
    doesn't call the registerd functions in reverse order, so our cleanup
    would run *after* the rmtree call regsitered by buildoutSetup, which is
    too late.
    daybarr committed Apr 24, 2017
    Configuration menu
    Copy the full SHA
    502e3ad View commit details
    Browse the repository at this point in the history
  3. Change case of demo => Demo

    Because this triggers issue #11 on Windows, so we can test that it's
    fixed.
    daybarr committed Apr 24, 2017
    Configuration menu
    Copy the full SHA
    1f51489 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    343ce30 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2017

  1. Only monkey patch distros_for_filename for .whl

    Seems like it might be safer
    daybarr committed Apr 25, 2017
    Configuration menu
    Copy the full SHA
    4be9306 View commit details
    Browse the repository at this point in the history