Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux support #831

Open
wants to merge 22 commits into
base: next
Choose a base branch
from
Open

Linux support #831

wants to merge 22 commits into from

Conversation

JamesLindsay0
Copy link
Contributor

@JamesLindsay0 JamesLindsay0 commented Jul 22, 2024 •
edited
Loading

Goal

Add linux support.

Changeset

  • Changes to build scripts to allow linux support
  • Documentation on linux setup
  • Bump mazerunner version to fix curl version mismatch
  • Linux specific metadata: memory and disk usage.

Testing

  • Manual testing that the reported values are correct.
  • MazeRunner Linux tests run locally (not yet able to test on the CI due to the agents not having the linux build component).

@JamesLindsay0 JamesLindsay0 marked this pull request as ready for review July 23, 2024 09:34
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Jul 23, 2024 •
edited
Loading

Build size impact

Format Size impact of Bugsnag (kB)
IL2CPP APK 2467.2
IL2CPP IPA 1542.17

Generated by 🚫 Danger

@richardelms
Copy link
Contributor

Looking great so far, let's try and get the mazerunner stuff in the same PR

twometresteve
twometresteve reviewed Aug 6, 2024
View reviewed changes
Copy link
Contributor

@twometresteve twometresteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice looking change on the whole, good work.

.buildkite/block.full.yml Show resolved Hide resolved
.buildkite/pipeline.linux.full.yml Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Gemfile Outdated Show resolved Hide resolved
Gemfile.lock Outdated Show resolved Hide resolved
src/BugsnagUnity/Native/Linux/NativeClient.cs Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like @richardelms to check this file over when he's back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twometresteve twometresteve twometresteve left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JamesLindsay0 @bugsnagbot @richardelms @twometresteve