Reinstate skipped native stack tests for android #2185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Reinstates skipped native stacktrace tests for Android on New Architecture - these were previously being skipped due to an issue in React Native, where native promise rejections from Turbo Modules were not an instance of
Error
in JS. This has now been fixed: facebook/react-native@f4b0fcbDesign
Although the issue has been fixed in React Native (promise rejections from Turbo Modules are now
Error
s in JS), the behaviour in Turbo Modules is still different vs legacy Native Modules - in the Old Architecture native promise rejections preserved the JS stack frames from before the call to the native module. This is no longer the case in Turbo Modules, which means events only contain native stack frames.The test therefore skips the JS stack frame assertion on New Architecture.