Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate skipped native stack tests for android #2185

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

yousif-bugsnag
Copy link
Contributor

Goal

Reinstates skipped native stacktrace tests for Android on New Architecture - these were previously being skipped due to an issue in React Native, where native promise rejections from Turbo Modules were not an instance of Error in JS. This has now been fixed: facebook/react-native@f4b0fcb

Design

Although the issue has been fixed in React Native (promise rejections from Turbo Modules are now Errors in JS), the behaviour in Turbo Modules is still different vs legacy Native Modules - in the Old Architecture native promise rejections preserved the JS stack frames from before the call to the native module. This is no longer the case in Turbo Modules, which means events only contain native stack frames.

The test therefore skips the JS stack frame assertion on New Architecture.

Copy link

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 44.21 kB 13.51 kB
After 44.21 kB 13.51 kB
± No change No change

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against 0a45b7d

@yousif-bugsnag yousif-bugsnag merged commit 9b6b03e into next Aug 22, 2024
69 checks passed
@yousif-bugsnag yousif-bugsnag deleted the PLAT-12193/android-promise-rejections branch August 22, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants