-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix electron v8 #2141
Fix electron v8 #2141
Conversation
9510cc2
to
23c3ac6
Compare
23c3ac6
to
d7d5811
Compare
@djskinner you can resolve the electron issue by pinning |
using http://locahost:65536/ is causing an invalid URL unhandled exception
"1": "{TYPE:string}" | ||
} | ||
}], | ||
"stacktrace": [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stacktraces now look like this:
{
"errorClass": "ReferenceError",
"errorMessage": "something bad",
"type": "electronnodejs",
"stacktrace": [
{
"file": ".webpack/main/index.js",
"method": "ClientRequest.notify",
"lineNumber": 2,
"columnNumber": 86370,
"code": {
"1": "/*! For license information please see index.js.LICENSE.txt */",
"2": "(()=>{var e={1821:e=>{e.exports=class{constructor(e,a,i,n=new Date){this.type=i,this.message=e,this.metadata=a,this.timestamp=n}toJSON(){return{type:this.type,name:this.message,timestamp:this.timestam"
}
},
{
"file": "node:events",
"method": "ClientRequest.emit",
"lineNumber": 531,
"columnNumber": 35
},
{
"file": "node:electron/js2c/browser_init",
"method": "SimpleURLLoaderWrapper.<anonymous>",
"lineNumber": 2,
"columnNumber": 114542
},
{
"file": "node:events",
"method": "SimpleURLLoaderWrapper.emit",
"lineNumber": 519,
"columnNumber": 28
}
],
"message": "something bad"
}
With the original fixture, the error is:
✖ Then the contents of an event request matches "main/breadcrumbs/network/error.json" # test/electron/features/support/steps/request-steps.js:202
Error: expect.toContainPayload(expected) - Nearest match (of 1):
.events.0.exceptions.0.stacktrace.0.file: Expected an exact match
Expected: ./src/errors.js
Received: node:events
.events.0.exceptions.0.stacktrace.0.lineNumber: Expected an exact match
Expected: 18
Received: 519
.events.0.exceptions.0.stacktrace.0.code: Expected a value but was undefined
Expected: {
"1": "{TYPE:string}"
}
Received: undefined
at World.<anonymous> (/Users/dan.skinner/bugsnag-js/test/electron/features/support/steps/request-steps.js:212:20)
Goal
Fix the electron tests on v8 branch
Design
Set
max_body_size: 25mb
on the verdaccio config (local npm where packages are published for the electron tests) to allow for the increased size of@bugsnag/react-native
in v8.Note the increase in size is expected and is because it contains both prefabs (which are unstripped and have a ton of extra debug info), and the classic JNI .so files. Depending on peoples builds only one gets used, and prefabs are processed before being included in the app. The size of .apk files doesn't get affected, just the .aar files.