Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity migration to spire #63

Merged
merged 14 commits into from
Jul 27, 2023
Merged

Entity migration to spire #63

merged 14 commits into from
Jul 27, 2023

Conversation

kompotkot
Copy link
Collaborator

@kompotkot kompotkot commented Jul 11, 2023

Changes

The archetecture with separate Entity API service showed weaknesses in response time. So in order to imcrease spead of communications with journal-based services we decided to merge Entity API to Spire API.

Here representation approach. Where we not modify original database structure of journals with entites and return formatted reposnse depends on user request.
During iteraction with Journal Spire API client call endpoints journals/ or collections/ depends what representation of journal entries they expect:

class JournalRepresentationTypes(Enum):
    COLLECTION = "collection"
    JOURNAL = "journal"

After it response will be returned based on representation.

scheme

How to test these changes?

Tested locally

Related issues

@kompotkot
Copy link
Collaborator Author

kompotkot commented Jul 11, 2023

@bugout-dev check

  • Migrate all main Entity API endpoints
  • Migrate all public Entity API endpoints
  • Set AWS routing to Spire API
  • Add env variables from Entity API to be availabe at Spire API machines
  • Update python client of Entity API
  • In EntitySearchResponse modified entities -> results as in original search response
  • In EntityResponse modified entity_id -> id as in original response

@kompotkot kompotkot marked this pull request as draft July 24, 2023 08:31
@kompotkot kompotkot merged commit 814d083 into main Jul 27, 2023
1 of 3 checks passed
@kompotkot kompotkot deleted the spire-entity-extention branch July 27, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant