Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete entries_tags and create entries_tags endpoints. #62

Merged
merged 6 commits into from
May 22, 2023

Conversation

Andrei-Dolgolev
Copy link
Contributor

@Andrei-Dolgolev Andrei-Dolgolev commented May 16, 2023

Changes

requests:

create:

POST  http://127.0.0.1:7475/journals/<journal_id>/bulk_entries_tags
Authorization: Bearer <token>


{
    "entries": [
        {
            "journal_entry_id": "58831735-df1b-4715-91a2-11b1ffe29cf4",
            "tags": ["#test", "#test2"]
        },
        {
            "journal_entry_id": "f0722d0d-24c6-4a38-8988-15ce7dc152d5",
            "tags": ["#test", "#test2"]
        },
        {
            "journal_entry_id": "5edc1e37-0613-494a-a04b-d5cd8e193c96",
            "tags": ["#test", "#test2"]
        },
        {
            "journal_entry_id": "560f9b26-4451-433d-9f88-042df2e0c15d",
            "tags": ["#test", "#test2"]
        },
        {
            "journal_entry_id": "4e76caff-6513-42a4-96e0-5a5b6409e153",
            "tags": ["#test", "#test2"]
        },
        {
            "journal_entry_id": "9c4835e5-510b-43e9-a445-88d0ef1a7517",
            "tags": ["#test", "#test2"]
        },
        {
            "journal_entry_id": "49743238-043e-4e38-9b87-f42f46a0e94a",
            "tags": ["#test", "#test2"]
        },
        {
            "journal_entry_id": "3206fc7e-e7eb-4195-90a7-cec4bf83eb18",
            "tags": ["#test", "#test2"]
        },
        {
            "journal_entry_id": "68684d52-f15a-460e-8e43-15122b4e02d7",
            "tags": ["#test", "#test2"]
        },
        {
            "journal_entry_id": "d924e8bd-f182-4dd9-9083-cf1d064645f4",
            "tags": ["#test", "#test2"]
        }
    ]
}

delete

DELETE http://127.0.0.1:7475/journals/<journal_id>/bulk_entries_tags
Authorization: Bearer <token>


{
    "entries": [
        {
            "journal_entry_id": "58831735-df1b-4715-91a2-11b1ffe29cf4",
            "tags": ["#test", "#test2"]
        },
        {
            "journal_entry_id": "f0722d0d-24c6-4a38-8988-15ce7dc152d5",
            "tags": ["#test", "#test2"]
        },
        {
            "journal_entry_id": "5edc1e37-0613-494a-a04b-d5cd8e193c96",
            "tags": ["#test", "#test2"]
        },
        {
            "journal_entry_id": "560f9b26-4451-433d-9f88-042df2e0c15d",
            "tags": ["#test", "#test2"]
        },
        {
            "journal_entry_id": "4e76caff-6513-42a4-96e0-5a5b6409e153",
            "tags": ["#test", "#test2"]
        },
        {
            "journal_entry_id": "9c4835e5-510b-43e9-a445-88d0ef1a7517",
            "tags": ["#test", "#test2"]
        },
        {
            "journal_entry_id": "49743238-043e-4e38-9b87-f42f46a0e94a",
            "tags": ["#test", "#test2"]
        },
        {
            "journal_entry_id": "3206fc7e-e7eb-4195-90a7-cec4bf83eb18",
            "tags": ["#test", "#test2"]
        },
        {
            "journal_entry_id": "68684d52-f15a-460e-8e43-15122b4e02d7",
            "tags": ["#test", "#test2"]
        },
        {
            "journal_entry_id": "d924e8bd-f182-4dd9-9083-cf1d064645f4",
            "tags": ["#test", "#test2"]
        }
    ]
}

speed metrics test: 2 entries 2 tags

# initial server start
INFO:spire.journal.api:ensure permissions: 3.9065678119659424
INFO:spire.journal.api:find journal: 0.34834909439086914
INFO:spire.journal.api:create tags: 0.8616104125976562
INFO:spire.journal.api:get journal entries: 0.482208251953125
INFO:spire.journal.api:bulk create entries elastic: 0.5705502033233643

INFO:spire.journal.api:ensure permissions: 0.8773183822631836
INFO:spire.journal.api:find journal: 0.3005661964416504
INFO:spire.journal.api:create tags: 0.7885816097259521
INFO:spire.journal.api:get journal entries: 0.4267129898071289
INFO:spire.journal.api:bulk create entries elastic: 0.7579469680786133

NFO:spire.journal.api:ensure permissions: 0.7112686634063721
INFO:spire.journal.api:find journal: 0.28923773765563965
INFO:spire.journal.api:create tags: 0.6659467220306396
INFO:spire.journal.api:get journal entries: 0.4205331802368164
INFO:spire.journal.api:bulk create entries elastic: 0.7230491638183594

20 dublicated of 2 entries 2 tags

INFO:spire.journal.api:ensure permissions: 0.9138748645782471
INFO:spire.journal.api:find journal: 0.32326197624206543
INFO:spire.journal.api:create tags: 0.8989837169647217
INFO:spire.journal.api:get journal entries: 0.5103013515472412
INFO:spire.journal.api:bulk create entries elastic: 0.8369154930114746

10 entries 2 tags

INFO:spire.journal.api:ensure permissions: 1.077878713607788
INFO:spire.journal.api:find journal: 0.44988203048706055
INFO:spire.journal.api:create tags: 0.9956307411193848
INFO:spire.journal.api:get journal entries: 0.6966845989227295
INFO:spire.journal.api:bulk create entries elastic: 0.937659502029419

INFO:spire.journal.api:ensure permissions: 0.7481000423431396
INFO:spire.journal.api:find journal: 0.32958173751831055
INFO:spire.journal.api:create tags: 0.9166326522827148
INFO:spire.journal.api:get journal entries: 0.6533544063568115
INFO:spire.journal.api:bulk create entries elastic: 0.6927003860473633

INFO:spire.journal.api:ensure permissions: 4.255248785018921
INFO:spire.journal.api:find journal: 0.34816527366638184
INFO:spire.journal.api:create tags: 0.8944802284240723
INFO:spire.journal.api:get journal entries: 0.49135518074035645
INFO:spire.journal.api:bulk create entries elastic: 1.078730583190918

How to test these changes?

Related issues

Copy link
Collaborator

@kompotkot kompotkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sml changes

spire/journal/api.py Outdated Show resolved Hide resolved
spire/journal/data.py Outdated Show resolved Hide resolved
spire/journal/data.py Outdated Show resolved Hide resolved
spire/journal/actions.py Outdated Show resolved Hide resolved
spire/journal/actions.py Outdated Show resolved Hide resolved
spire/journal/actions.py Outdated Show resolved Hide resolved
spire/journal/actions.py Outdated Show resolved Hide resolved
spire/journal/actions.py Outdated Show resolved Hide resolved
spire/journal/actions.py Outdated Show resolved Hide resolved
spire/journal/actions.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@kompotkot kompotkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@Andrei-Dolgolev Andrei-Dolgolev merged commit 5e3c72b into main May 22, 2023
@Andrei-Dolgolev Andrei-Dolgolev deleted the batch-tags-update branch May 22, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants