Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix panics inside HTTP protocol code #408, and this case is quite interesting.
I could not replicate bug manually and decided to try a fuzzing.
The basic idea that it is that fuzzer is massively scaled random generator, which tries to run your function with all possible combinations. And Golang have a really nice one: https://github.com/dvyukov/go-fuzz
It's quite easy to use it, for testing proto library command was:
After it finished, we need to look at
crashers
directory, which will contain file with panic trace, and actual input which caused the issue.Take a look PR itself to understand what it does.