Replace Macros with Aliases #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This looks okay in principle, but I think I'll want to add a CI build configuration to build with the |
|
Hi, can you rebase this PR over the latest master branch please? |
ds5678
force-pushed
the
replace-macros-with-alias
branch
from
5f21484
to
3c3b913
Compare
|
All good? |
|
Thanks! Just one minor comment, and I'll merge it once that is changed. I suppose Clang/ObjC doesn't have attribute alias, but what you've done is fine as well, since it's just an implementation detail now. |
btzy
reviewed
Dec 17, 2023
|
Seems like NFD_PickFolderU8 is missing on nfd_gtk.cpp? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is intended to address issues with creating wrappers in other languages. I made Utf8 function exports available on all platforms.
Supercedes #118
Resolves #117