-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Macros with Aliases #121
Conversation
Thanks! This looks okay in principle, but I think I'll want to add a CI build configuration to build with the |
Hi, can you rebase this PR over the latest master branch please? |
5f21484
to
3c3b913
Compare
All good? |
Thanks! Just one minor comment, and I'll merge it once that is changed. I suppose Clang/ObjC doesn't have attribute alias, but what you've done is fine as well, since it's just an implementation detail now. |
Seems like NFD_PickFolderU8 is missing on nfd_gtk.cpp? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This pull request is intended to address issues with creating wrappers in other languages. I made Utf8 function exports available on all platforms.
Supercedes #118
Resolves #117