Add the truncate parameter to kraken.spot.Trade.create_order
#95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btschwertfeger
added
enhancement
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #95 +/- ##
==========================================
+ Coverage 86.03% 86.33% +0.29%
==========================================
Files 17 18 +1
Lines 1425 1456 +31
==========================================
+ Hits 1226 1257 +31
Misses 199 199
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Hey @andyDoucette - is there anything missing? |
btschwertfeger
deleted the
94-tradecreate_order-ability-to-use-floats-as-trade-amounts-or-prices
branch
btschwertfeger
added a commit
that referenced
this pull request
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As described in #94, in some cases the Kraken API returns invalid volume or invalid price errors, since Python creates strings like "1e-05" from float values like 0.00001 which cannot be interpreted by the Kraken API. To also ensure that users of the python-kraken-sdk don't need to worry about the right rounding, the new
truncatefunction was implemented that can roundvolumeandprice. If the newtruncateparameter ofkraken.spot.Trade.create_orderis set toTrue, the price and volume will be rounded to the lowest - last decimal.The
price2parameter is not affected since that would break the custom commands described in Kraken Docs addOrder Closes: #94Also the
kraken.spot.Trade.create_orderexamples were adjusted. Closes #96