Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve "Add withdraw_methods and withdraw_addresses to kraken.spot.Funding" #175

Conversation

btschwertfeger
Copy link
Owner

This PR is adding the new endpoints withdraw_methods and withdraw_addresses to the kraken.spot.Funding client.

@btschwertfeger btschwertfeger added enhancement New feature or request Spot Topic related to Spot trading labels Dec 6, 2023
@btschwertfeger btschwertfeger added this to the Future Release milestone Dec 6, 2023
@btschwertfeger btschwertfeger self-assigned this Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #175 (3a589ae) into master (93cd118) will decrease coverage by 1.69%.
The diff coverage is 56.52%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
- Coverage   90.40%   88.72%   -1.69%     
==========================================
  Files          21       21              
  Lines        1845     1871      +26     
==========================================
- Hits         1668     1660       -8     
- Misses        177      211      +34     
Flag Coverage Δ
unittests 88.72% <56.52%> (-1.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
kraken/base_api/__init__.py 89.65% <100.00%> (-0.30%) ⬇️
kraken/futures/trade.py 96.20% <100.00%> (ø)
kraken/futures/user.py 66.66% <100.00%> (-19.70%) ⬇️
kraken/spot/__init__.py 100.00% <ø> (ø)
kraken/spot/trade.py 94.33% <100.00%> (ø)
kraken/spot/user.py 99.12% <100.00%> (ø)
kraken/spot/websocket_v1.py 97.16% <100.00%> (ø)
kraken/spot/funding.py 50.74% <9.09%> (-20.37%) ⬇️

@btschwertfeger btschwertfeger merged commit 94cb0bd into master Dec 6, 2023
20 of 21 checks passed
@btschwertfeger btschwertfeger deleted the 174-add-withdrawmethods-and-withdrawaddresses-to-krakenspotfunding branch December 6, 2023 20:05
btschwertfeger added a commit that referenced this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Spot Topic related to Spot trading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add withdraw_methods and withdraw_addresses to kraken.spot.Funding
1 participant