Fix "kraken.spot.OrderbookClient is not able to resubscribe to book feeds after connection lost"
#149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btschwertfeger
changed the title
kraken.spot.OrderbookClient is not able to resubscribe to book feeds after connection lost"
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
==========================================
+ Coverage 90.04% 90.10% +0.05%
==========================================
Files 20 20
Lines 1728 1738 +10
==========================================
+ Hits 1556 1566 +10
Misses 172 172
Flags with carried forward coverage won't be shown. Click here to find out more.
|
btschwertfeger
deleted the
148-krakenspotorderbookclient-is-not-able-to-resubscribe-to-book-feeds-after-connection-lost
branch
btschwertfeger
added a commit
that referenced
this pull request
Mar 12, 2024
… feeds after connection lost" (#149)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
During the investigation of the bug it has shown, that the bug described in #148 also occurs for the ohlc, trade and ticker feeds. This has been fixed by pre-processing the subscriptions before caching.