Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate and apply ruff #142

Merged
merged 10 commits into from
Aug 1, 2023

Conversation

btschwertfeger
Copy link
Owner

@btschwertfeger btschwertfeger commented Jul 31, 2023

Summary

Ruff is now used as the main linter. It is way faster than raw pylint or flake8 and combines the core functionalities used in this project.

Since ruff is used and applied, it acts like a shotgun and creates a bunch of changes.

Breaking changes

  • Some Errors have changed from ValueError => TypeError | AttributeError

@btschwertfeger btschwertfeger self-assigned this Jul 31, 2023
@btschwertfeger btschwertfeger added this to the v1.6.0 milestone Jul 31, 2023
@btschwertfeger btschwertfeger changed the title 140 use ruff instead of pylint and friends Integrate and apply ruff Jul 31, 2023
@btschwertfeger btschwertfeger mentioned this pull request Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #142 (a34392e) into master (ef0f49f) will decrease coverage by 0.03%.
The diff coverage is 80.88%.

❗ Current head a34392e differs from pull request most recent head 50c343e. Consider uploading reports for the commit 50c343e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
- Coverage   90.00%   89.97%   -0.03%     
==========================================
  Files          20       20              
  Lines        1711     1716       +5     
==========================================
+ Hits         1540     1544       +4     
- Misses        171      172       +1     
Flag Coverage Δ
unittests 89.97% <80.88%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
kraken/futures/market.py 91.39% <ø> (ø)
kraken/spot/funding.py 72.97% <ø> (ø)
kraken/spot/market.py 100.00% <ø> (ø)
kraken/spot/staking.py 70.83% <ø> (-4.17%) ⬇️
kraken/futures/websocket/__init__.py 78.61% <68.18%> (ø)
kraken/spot/websocket/connectors.py 79.78% <73.33%> (+0.43%) ⬆️
kraken/base_api/__init__.py 90.52% <75.00%> (-0.05%) ⬇️
kraken/futures/ws_client.py 87.35% <90.00%> (+0.45%) ⬆️
kraken/exceptions/__init__.py 99.20% <100.00%> (ø)
kraken/futures/trade.py 96.15% <100.00%> (ø)
... and 7 more

@btschwertfeger btschwertfeger added enhancement New feature or request Breaking Breaking changes labels Aug 1, 2023
@btschwertfeger btschwertfeger added Futures Topic related to Futures trading Spot Topic related to Spot trading labels Aug 1, 2023
@btschwertfeger btschwertfeger linked an issue Aug 1, 2023 that may be closed by this pull request
@btschwertfeger btschwertfeger marked this pull request as ready for review August 1, 2023 16:33
@btschwertfeger btschwertfeger merged commit 24ad552 into master Aug 1, 2023
57 checks passed
@btschwertfeger btschwertfeger deleted the 140-use-ruff-instead-of-pylint-and-friends branch August 1, 2023 16:57
btschwertfeger added a commit that referenced this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Breaking changes enhancement New feature or request Futures Topic related to Futures trading Spot Topic related to Spot trading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ruff instead of pylint and friends
1 participant