Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let kraken.spot.OrderbookClient use Spot Websocket API v2 #139

Merged

Conversation

btschwertfeger
Copy link
Owner

Summary

The Spot orderbook client was upgraded to use the Kraken Spot websocket API v2.

This is a breaking change, since the raw messages sent by Kraken will be forwarded (as before) to the on_book_update function- BUT they are now in a different format.

https://docs.kraken.com/websockets-v2/#book

@btschwertfeger btschwertfeger added the Breaking Breaking changes label Jul 30, 2023
@btschwertfeger btschwertfeger added this to the Next Release milestone Jul 30, 2023
@btschwertfeger btschwertfeger self-assigned this Jul 30, 2023
@btschwertfeger btschwertfeger added enhancement New feature or request Spot Topic related to Spot trading labels Jul 30, 2023
@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Merging #139 (09ddfc1) into master (16627d8) will decrease coverage by 0.06%.
The diff coverage is 94.59%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
- Coverage   90.05%   90.00%   -0.06%     
==========================================
  Files          20       20              
  Lines        1720     1711       -9     
==========================================
- Hits         1549     1540       -9     
  Misses        171      171              
Flag Coverage Δ
unittests 90.00% <94.59%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
kraken/spot/websocket_v2.py 96.77% <50.00%> (ø)
kraken/spot/orderbook.py 89.02% <96.42%> (-1.09%) ⬇️
kraken/spot/funding.py 72.97% <100.00%> (ø)
kraken/spot/market.py 100.00% <100.00%> (ø)
kraken/spot/staking.py 75.00% <100.00%> (ø)
kraken/spot/trade.py 94.28% <100.00%> (ø)
kraken/spot/user.py 99.12% <100.00%> (ø)
kraken/spot/websocket/connectors.py 79.34% <100.00%> (ø)

@btschwertfeger btschwertfeger marked this pull request as ready for review July 31, 2023 18:51
@btschwertfeger btschwertfeger merged commit ef0f49f into master Jul 31, 2023
59 checks passed
@btschwertfeger btschwertfeger deleted the let-spot-orderbookclient-use-spot-websocket-api-v2 branch July 31, 2023 18:51
@btschwertfeger btschwertfeger linked an issue Aug 1, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Breaking changes enhancement New feature or request Spot Topic related to Spot trading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let kraken.spot.OrderbookClient use the Spot Websocket API v2
1 participant