-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let kraken.spot.OrderbookClient
use Spot Websocket API v2
#139
Merged
btschwertfeger
merged 43 commits into
master
from
let-spot-orderbookclient-use-spot-websocket-api-v2
Jul 31, 2023
Merged
Let kraken.spot.OrderbookClient
use Spot Websocket API v2
#139
btschwertfeger
merged 43 commits into
master
from
let-spot-orderbookclient-use-spot-websocket-api-v2
Jul 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #139 +/- ##
==========================================
- Coverage 90.05% 90.00% -0.06%
==========================================
Files 20 20
Lines 1720 1711 -9
==========================================
- Hits 1549 1540 -9
Misses 171 171
Flags with carried forward coverage won't be shown. Click here to find out more.
|
btschwertfeger
added a commit
that referenced
this pull request
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Spot orderbook client was upgraded to use the Kraken Spot websocket API v2.
This is a breaking change, since the raw messages sent by Kraken will be forwarded (as before) to the on_book_update function- BUT they are now in a different format.
https://docs.kraken.com/websockets-v2/#book