-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Kraken Websockets API v2; add kraken.spot.KrakenSpotWebsocketClientV2
; internals
#131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
kraken.spot.KrakenSpotWebsocketClientV2
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #131 +/- ##
==========================================
+ Coverage 87.57% 90.00% +2.42%
==========================================
Files 18 20 +2
Lines 1569 1720 +151
==========================================
+ Hits 1374 1548 +174
+ Misses 195 172 -23
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kraken.spot.KrakenSpotWebsocketClientV2
kraken.spot.KrakenSpotWebsocketClientV2
; internals
btschwertfeger
added a commit
that referenced
this pull request
Mar 12, 2024
…ketClientV2`; internals (#131)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR provides a new client that can be used to connect to the Kraken Websocket API V2 (
kraken.spot.KrakenSpotWSClientV2
).To do so, new base classes were used to support both API v1 and v2.
Breaking
msg
ofkraken.spot.KrakenSpotWSClient.on_message
was renamed tomessage
.msg
ofkraken.spot.KrakenSpotWSClient.send_message
was renamed tomessage
.Todo's / Changes
kraken.spot.KrakenSpotWSClientV2
and create a base class to support API v1 and v2__all__
in python modules