Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DecodeNoLimitGeneric to bech32.go #2186

Merged
merged 1 commit into from
May 24, 2024

Conversation

MarcoEzekiel
Copy link
Contributor

@MarcoEzekiel MarcoEzekiel commented May 9, 2024

a fix for issue Public DecodeNoLimit(encoded) #2185

btcutil/bech32/bech32.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. Can you please squash the two commits and add the btcutil/bech32: prefix to the commit message?

This exposes publicly the ability to decode arbitrary-length bech32
strings and return the bech32 version that was used in the encoding. It
provides the underlying functionality for both DecodeNoLimit and
DecodeGeneric.
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM 🎉

@coveralls
Copy link

coveralls commented May 14, 2024

Pull Request Test Coverage Report for Build 9021239611

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.009%) to 56.881%

Files with Coverage Reduction New Missed Lines %
connmgr/connmanager.go 1 86.27%
btcutil/bech32/bech32.go 11 95.9%
Totals Coverage Status
Change from base Build 8881487645: 0.009%
Covered Lines: 29455
Relevant Lines: 51784

💛 - Coveralls

@leandrogomesmachado
Copy link

❤️ Good job

@MarcoEzekiel
Copy link
Contributor Author

Any Chance this will be merged soon?

@guggero guggero merged commit d2d286f into btcsuite:master May 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants