Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockchain: export CheckSerializedHeight #2051

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

Crypt-iQ
Copy link
Collaborator

Some callers only want to check the coinbase height rather than be given the height. Also reduce allocations for cb height parsing

parsing

Some callers only want to check the coinbase height rather than be given
the height.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6695568816

  • 20 of 29 (68.97%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 55.287%

Changes Missing Coverage Covered Lines Changed/Added Lines %
blockchain/validate.go 20 29 68.97%
Totals Coverage Status
Change from base Build 6591877100: 0.02%
Covered Lines: 26939
Relevant Lines: 48726

💛 - Coveralls

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚵🏼‍♂️

@Roasbeef Roasbeef merged commit e16cdb6 into btcsuite:master Oct 31, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants