psbt: add verification method for utxo data #1964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
reviewed
Mar 20, 2023
ziggie1984
force-pushed
the
psbt-nil-pointer-bug
branch
from
268617b
to
298ab4b
Compare
|
Thank you for taking a look so fast, really appreciate this :) |
ziggie1984
force-pushed
the
psbt-nil-pointer-bug
branch
from
298ab4b
to
8c2adbc
Compare
7 tasks
ziggie1984
force-pushed
the
psbt-nil-pointer-bug
branch
from
8c2adbc
to
42d675e
Compare
btcutil/psbt/utils.go
Outdated
| // type and the second reason is that the sighash calculation for taproot inputs | ||
| // include the previous output pkscripts. | ||
| func InputsReadyToSign(packet *Packet) error { | ||
| VerifyInputOutputLen(packet, true, true) |
There was a problem hiding this comment.
I guess we want to return an error if this function "fails"?
There was a problem hiding this comment.
Totally thank you
the new InputsReadyToSign method makes sure that inputs have either the nonWitnessUtxo or the witnessUtxo data set.
ziggie1984
force-pushed
the
psbt-nil-pointer-bug
branch
from
42d675e
to
b554add
Compare
Pull Request Test Coverage Report for Build 4476808113
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a method to verify the utxo data of a psbt package especially the
NonWitnessUtxo | WitnessUtxodata.This will be used in other packages to make sure we have the correct psbt structure with all relevant input fields populated.
Relates to lightningnetwork/lnd#7527
Happy to discuss other approaches, other PRs which call this function in lnd and btcwallet would follow if we want this function in this package ?