Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

base58: fix decoding issue #1923

Merged
merged 1 commit into from
Nov 18, 2022
Merged

base58: fix decoding issue #1923

merged 1 commit into from
Nov 18, 2022

Conversation

guggero
Copy link
Collaborator

@guggero guggero commented Nov 18, 2022

Fixes #1922.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3499853520

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 55.145%
Files with Coverage Reduction New Missed Lines %
connmgr/connmanager.go 2 86.07%
Totals Coverage Status
Change from base Build 3433070261: -0.001%
Covered Lines: 26555
Relevant Lines: 48155
💛 - Coveralls

sputn1ck
sputn1ck approved these changes Nov 18, 2022
View reviewed changes
Copy link
Collaborator

@sputn1ck sputn1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK LGTM !

Roasbeef
Roasbeef approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💎

@guggero guggero merged commit 02c854e into btcsuite:master Nov 18, 2022
@guggero guggero deleted the base58-fix branch November 18, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roasbeef Roasbeef Roasbeef approved these changes

@sputn1ck sputn1ck sputn1ck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DecodeAddress panic when address contains emoji characters.
4 participants
@guggero @coveralls @Roasbeef @sputn1ck