make: add install and release-install goals #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7164900054
💛 - Coveralls |
sputn1ck
approved these changes
Nov 17, 2022
jcvernaleo
requested changes
Feb 22, 2023
| @@ -40,3 +40,10 @@ coverage.txt | |||
| btcec/coverage.txt | |||
| btcutil/coverage.txt | |||
| btcutil/psbt/coverage.txt | |||
|
|
|||
| # Binaries produced by "make build" | |||
| /addblock | |||
There was a problem hiding this comment.
Is the path here right? Why /addblock and not just addblock?
There was a problem hiding this comment.
AFAIK /addblock will match any file or directory that is located in the root directory of the repository, while addblock will match any file or directory in any directory within the repository. It will match both files and directories with that name, meaning it would patternmatch more than just the generated binaries. (if they wouldn't have been comitted already)
sputn1ck
approved these changes
Feb 22, 2023
jcvernaleo
approved these changes
Dec 9, 2023
The use of the GO111MODULE environment variable doesn't have any effect anymore and hasn't for a couple of versions. The default was set to "on" a while back, so we can remove that variable everywhere.
To simplify building the release-grade (stripped and reproducible) binaries from source, we add the install and release-install make goals. Running either of the commands will create binaries in the $GOPATH/bin directories. The main difference between the two goals is that the release-install will not contain any local paths and no debug information.
guggero
force-pushed
the
build-improvements
branch
from
5ccb7be
to
ce3ca97
Compare
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To simplify building the release-grade (stripped and
reproducible) binaries from source, we add the install and
release-install make goals. Running either of the commands will create
binaries in the $GOPATH/bin directories.
The main difference between the two goals is that the release-install
will not contain any local paths and no debug information.