Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpctest: ensure rpclisten is set to an available port #1806

Merged
merged 1 commit into from
Apr 9, 2022
Merged

rpctest: ensure rpclisten is set to an available port #1806

merged 1 commit into from
Apr 9, 2022

Conversation

arshbot
Copy link
Contributor

@arshbot arshbot commented Feb 7, 2022

Replaces the implementation of generateListeningAddresses to use NextAvailablePort from lntest. Would have imported directly, however this creates a circular dependency.

carlaKC
carlaKC suggested changes Feb 9, 2022
View reviewed changes
Copy link

@carlaKC carlaKC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we can skip these changes and just set ListenAddressGenerator as done in lnd?

integration/rpctest/rpc_harness.go Outdated Show resolved Hide resolved
integration/rpctest/rpc_harness.go Show resolved Hide resolved
@arshbot
Copy link
Contributor Author

arshbot commented Feb 9, 2022 •
edited
Loading

I think that we can skip these changes and just set ListenAddressGenerator as done in lnd?

Disagree, that's a bandaid for this upstream issue. I don't mind having that fix as well, but rpclisten shouldn't just be set to a random port without testing.

@carlaKC
Copy link

carlaKC commented Feb 10, 2022

Disagree, that's a bandaid for this upstream issue. I don't mind having that fix as well, but rpclisten shouldn't just be set to a random port without testing.

Totally! Worth fixing here so that we don't need the workaround, but in the meantime this doesn't need to block downstream.

carlaKC
carlaKC approved these changes Feb 10, 2022
View reviewed changes
Copy link

@carlaKC carlaKC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1820138601

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.676%
Totals Coverage Status
Change from base Build 1808348675: 0.0%
Covered Lines: 1231
Relevant Lines: 1545
💛 - Coveralls

jcvernaleo
jcvernaleo approved these changes Apr 9, 2022
View reviewed changes
Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jcvernaleo jcvernaleo merged commit e0149d6 into btcsuite:master Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcvernaleo jcvernaleo jcvernaleo approved these changes

@carlaKC carlaKC carlaKC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arshbot @carlaKC @coveralls @jcvernaleo