Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpcclient: add deriveaddresses RPC command #1631

Merged
merged 1 commit into from
Sep 14, 2020
Merged

rpcclient: add deriveaddresses RPC command #1631

merged 1 commit into from
Sep 14, 2020

Conversation

onyb
Copy link
Collaborator

@onyb onyb commented Sep 13, 2020

I have also rearranged some command structs in btcjson/chainsvrcmds.go alphabetically to follow the convention.

@onyb onyb added the rpc label Sep 13, 2020
@onyb onyb added this to the 0.22.0 milestone Sep 13, 2020
@coveralls
Copy link

coveralls commented Sep 13, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 253949886

  • 24 of 44 (54.55%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.007%) to 53.584%
Changes Missing Coverage Covered Lines Changed/Added Lines %
rpcclient/chain.go 0 20 0.0%
Files with Coverage Reduction New Missed Lines %
rpcclient/chain.go 1 3.13%
btcec/signature.go 3 92.48%
Totals Coverage Status
Change from base Build 253941097: 0.007%
Covered Lines: 20669
Relevant Lines: 38573
💛 - Coveralls

@ipriver
Copy link
Contributor

ipriver commented Sep 13, 2020

One note:
Pls, don't merge your separate changes into one commit in the future. It makes it difficult to review your PR as it's hard to understand when a function was simply rearranged or it has changed.

jcvernaleo
jcvernaleo approved these changes Sep 14, 2020
View reviewed changes
Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jcvernaleo jcvernaleo merged commit c693bd8 into btcsuite:master Sep 14, 2020
@onyb onyb deleted the derive-addresses-rpcclient branch September 14, 2020 14:38
@jakesylvestre jakesylvestre mentioned this pull request Sep 25, 2020
Open
@onyb onyb mentioned this pull request Apr 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcvernaleo jcvernaleo jcvernaleo approved these changes

@jakesylvestre jakesylvestre jakesylvestre approved these changes

Assignees
No one assigned
Labels
rpc
Projects
None yet
Milestone
0.22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@onyb @coveralls @ipriver @jcvernaleo @jakesylvestre