Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix monetary unit #1614

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Fix monetary unit #1614

merged 1 commit into from
Aug 31, 2020

Conversation

wakiyamap
Copy link
Contributor

amount is BTC unit. ex. 0.00001234BTC
MaxSatoshi is satoshi unit. ex. 1234satoshi

onyb
onyb reviewed Aug 14, 2020
View reviewed changes
rpcserver.go Show resolved Hide resolved
onyb
onyb approved these changes Aug 14, 2020
View reviewed changes
Copy link
Collaborator

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK locally. ✅

jcvernaleo
jcvernaleo approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jcvernaleo jcvernaleo merged commit 36d4ae0 into btcsuite:master Aug 31, 2020
@wakiyamap wakiyamap deleted the fix_monetary_unit branch August 31, 2020 16:37
@onyb onyb mentioned this pull request Apr 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcvernaleo jcvernaleo jcvernaleo approved these changes

@onyb onyb onyb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wakiyamap @jcvernaleo @onyb