Implement signmessagewithprivkey JSON-RPC command (rpc server) #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindlof
changed the title
|
Because of this Satoshi was finally able to sign his message the next day 😂 |
onyb
reviewed
Aug 9, 2020
| func handleSignMessageWithPrivKey(s *rpcServer, cmd interface{}, closeChan <-chan struct{}) (interface{}, error) { | ||
| c := cmd.(*btcjson.SignMessageWithPrivKeyCmd) | ||
|
|
||
| wif, err := btcutil.DecodeWIF(c.PrivKey) |
There was a problem hiding this comment.
bitcoind rejects WIFs that do not belong to the current network. Or so it seems. Here's an example for you to reproduce using a mainnet WIF:
$ ./btcctl --regtest --rpcuser=aaaa --rpcpass=bbbb signmessagewithprivkey 5HueCGU8rMjxEXxiPuD5BDku4MkFqeZyd4dZ1jvhTVqvbTLvyTJ iamsatoshi
G+brEqKGQgPCSkPJrBau7x32eFhT3Y5YXdEXKG2bg2E2Tqi0lU54t+rYrEezLcSDLS4TM+/AO8a3A9ybAfvyMLY=
$ bitcoin-cli -regtest signmessagewithprivkey 5HueCGU8rMjxEXxiPuD5BDku4MkFqeZyd4dZ1jvhTVqvbTLvyTJ iamsatoshi
error code: -5
error message:
Invalid private keyThe fix would be to simply check wif.IsForNet(s.cfg.ChainParams).
There was a problem hiding this comment.
Yes this was the case. Fixed by checking wif.IsForNet(s.cfg.ChainParams) as you suggested.
Reuse the Bitcoin message signature header const also in verifymessage.
lindlof
force-pushed
the
signmessagewithprivkey
branch
from
24f0882
to
65c6956
Compare
|
Looks good to me/tested locally against 0.20.0/0.19.0 (on bitcoind side). Since I'm not as familiar with btcec, would prefer to have someone else look over it as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse the Bitcoin message signature header const
also in verifymessage.