BUG:dynamicbanscore deadlock

btcsuite · Mar 9, 2020 · 96f3808 · 96f3808
1 parent 9e94ccb
commit 96f3808
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/connmgr/dynamicbanscore.go b/connmgr/dynamicbanscore.go
@@ -71,7 +71,7 @@ type DynamicBanScore struct {
 func (s *DynamicBanScore) String() string {
 	s.mtx.Lock()
 	r := fmt.Sprintf("persistent %v + transient %v at %v = %v as of now",
-		s.persistent, s.transient, s.lastUnix, s.Int())
+		s.persistent, s.transient, s.lastUnix, s.int(time.Now()))
 	s.mtx.Unlock()
 	return r
 }

diff --git a/connmgr/dynamicbanscore_test.go b/connmgr/dynamicbanscore_test.go
@@ -66,3 +66,15 @@ func TestDynamicBanScoreReset(t *testing.T) {
 		t.Errorf("Failed to reset ban score.")
 	}
 }
+
+// TestDynamicBanScoreString
+func TestDynamicBanScoreString(t *testing.T) {
+	var bs DynamicBanScore
+	base := time.Now()
+
+	r := bs.increase(100, 50, base)
+	if r != 150 {
+		t.Errorf("Unexpected result %d after ban score increase.", r)
+	}
+	t.Log(bs.String())
+}