-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is it possible to control input level to each NAM model independently? #21
Comments
Some very good suggestions. I'll consider them all for the next development circle. |
Okay, done. There is now a input control for each neural model and the delay control act now as a delta delay (negative values means first model, positive values means second model). |
Wow, fantastic! Thanks for your effort! I was able to compile and run just fine. I can't load it in Guitarix, which I guess means the plugin doesn't meet requirements for Guitarix, but I think that's to be expected. In the big picture I was supposing that once all the dual parallel NAM issues were discussed/implemented here that one day you might be able to implement in the dual NAM guitarix version. I was able to insert it using Carla between mono and stereo Gtx but that's not an ideal solution. |
Okay, I've implemented support for the ctrl key (control) |
Super! I'll try this out. Seems like it should be able to let you set delay with the regular knob and phase with control. You can set delay first to get in the ballpark and then use control to do the fine tuning. |
This is a feature request.
I am interested in using two NAM profiles in parallel, but I am wondering if there could be a way to control the input levels to each NAM model independently. I find that in order to get the desired sound (i.e. the right amount of breakup) from each NAM that I have to carefully adjust the input gain. It is unlikely that two NAM models would require the exact same input level to achieve the desired amount of breakup. If there was an input control for each NAM file then I could do the fine tuning.
A related question, what is the location of the blend control in terms of signal flow? I was assuming it is located after the NAM models. Which of the following is describing the signal flow more accurately?:
Input > Blend > NAM1/2 > Output
Input > NAM1/2 > Blend > Output
I'm ignoring the IR's for the moment (I don't use IR's, just NAM), but my humble suggestion for gain-staging/signal flow is to remove the blend knob and instead have an input and output control for each NAM model. I believe an independent output control for each NAM model would be basically equivalent to the current "Blend plus Output" format. Myself I would find it more intuitive to have the following two sets of processing running in parallel:
Input 1>NAM1>Output 1
Input 2>NAM2>Delay>Output 2
I see the above as being essentially equivalent to these two lines running in parallel:
Input 1>NAM1>Blend>Output
Input 2>NAM2>Delay>Blend>Output
I believe the following two lines running in parallel describes the current version of the plugin:
Input>NAM1>Blend>Output
Input>NAM2>Delay>Blend>Output
I am assuming that this plugin is related to the Dual NAM option in Guitarix, which is the platform I use, and thus if it is possible to have independent input control for the two NAM models then it is also likely that it could be done in Guitarix as well. I was ideally hoping that I could use this LV2 plugin in Guitarix, which would give me the delay control (quite useful as NAM models seem to have very small delays built into them).
One final request would be to consider modifying the delay function to include both positive and negative delay amounts for the second model relative to the first. I am assuming the primary function of the delay is to phase-align or correct minor timing issues in each NAM model. If the only option is to delay the second NAM then one has to determine before hand which of the two models is early or late relative to the other, but this could be avoided if the delay knob on the GUI shows positive and negative values (default would be for delay knob to be at Noon with a value of 0). A 'negative' delay would be the equivalent of delaying NAM1 relative to NAM2 while a 'positive' delay would delay NAM2 relative to NAM1.
The text was updated successfully, but these errors were encountered: