fix(windows): escape prefix path on windows

Closes zkat#100
brianpeiris · Dec 7, 2017 · 1521744 · 1521744
1 parent 357e6ab
commit 1521744
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/index.js b/index.js
@@ -205,7 +205,7 @@ function getNpmCache (opts) {
 module.exports._buildArgs = buildArgs
 function buildArgs (specs, prefix, opts) {
   const args = ['install'].concat(specs)
-  args.push('--global', '--prefix', prefix)
+  args.push('--global', '--prefix', process.platform === 'win32' ? `"${prefix}"` : prefix)
   if (opts.cache) args.push('--cache', opts.cache)
   if (opts.userconfig) args.push('--userconfig', opts.userconfig)
   args.push('--loglevel', 'error', '--json')

diff --git a/test/index.js b/test/index.js
@@ -125,7 +125,7 @@ test('installPackages unit', t => {
       NPM_PATH,
       'install', 'installme@latest', 'file:foo',
       '--global',
-      '--prefix', 'myprefix',
+      '--prefix', isWindows ? '"myprefix"' : 'myprefix',
       '--loglevel', 'error',
       '--json'
     ], 'args to spawn were correct for installing requested package')