Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grep -f 0 #627

Merged
merged 1 commit into from
May 29, 2024
Merged

grep -f 0 #627

merged 1 commit into from
May 29, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented May 29, 2024

  • It is valid for a pattern file to be named "0" but this was not being ignored by grep
%cat > 0
main
puts
^D
%perl grep -nf 0 a.c
4:main(void)
6:	puts("yo");

@mknos
grep -f 0
d146331 
* It is valid for a pattern file to be named "0" but this was not being ignored by grep

%cat > 0
main
puts
^D
%perl grep -nf 0 a.c
4:main(void)
6:	puts("yo");
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: grep The grep program labels May 29, 2024
@briandfoy briandfoy merged commit 2069073 into briandfoy:master May 29, 2024
2 checks passed
@briandfoy briandfoy self-assigned this May 29, 2024
@briandfoy briandfoy added Type: bug an existing feature does not work Status: accepted The fix is accepted and removed Type: enhancement improve a feature that already exists Priority: low get to this whenever labels May 29, 2024
@briandfoy
Copy link
Owner

changes: allow the search pattern "0" by checking for a defined arg not the arg value

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: grep The grep program Status: accepted The fix is accepted Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy