Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a user submit a PG connstring with
?ssl=off
, while this is invalid, it's not failing the parsing, and connect() throws on:Because
Connection
extendsEventEmitter
, that exception is notcatch
-able with atry
/catch
around the call toclient.connect()
. I am following on the footsteps of #2569, and making sure that exception is properly caught internally.Ideally, this
?ssl=off
value should trigger a validation error, but:Added a unit test, that fails if
connection.js
is not patched: an unhandled exception bubbles up.