Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pg-pool Exception #2582

Closed
hartalex opened this issue Jul 27, 2021 · 5 comments
Closed

pg-pool Exception #2582

hartalex opened this issue Jul 27, 2021 · 5 comments

Comments

@hartalex
Copy link

hartalex commented Jul 27, 2021

TypeError: client.ref is not a function
at BoundPool._pulseQueue (../node_modules/pg-pool/index.js:140:14)

I'm using pg@8.6.0 which, as of today, now installs pg-pool@3.4.0

@brianc
Copy link
Owner

brianc commented Jul 27, 2021

That's unfortunate - AFAIK there's no way to retroactively update the old package to have it use the older version of pg-pool. I suggest you either upgrade pg to 8.7.0 or add pg-pool@3.3.0 to your package.json. I can patch pg-pool to not blow up if that method is missing as well.

@charmander
Copy link
Collaborator

@brianc Might want to unpublish pg-pool@3.4.0 and publish it as pg-pool@4.0.0, with the appropriate peerDependencies change?

@brianc
Copy link
Owner

brianc commented Jul 27, 2021

I'm patching pg-pool w/ semver patch to only call ref if it exists, so it'll maintain backwards compat w/ version mismatch. I'll be more careful about about the semver in the peerDeps in the future (I think a peerDep mismatch would still only throw a warning message out though, yeh?)

@brianc
Copy link
Owner

brianc commented Jul 27, 2021

k released new semver patch of pg-pool which should work with much older versions of pg - sorry about that!

@maxime-lenne
Copy link

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants